1Hive / time-lock-app

The Time Lock app enables Aragon organizations to require users transfer or temporarily lock tokens before forwarding an intent.
GNU General Public License v3.0
16 stars 11 forks source link

Improve the question marks detail #79

Open GriffGreen opened 4 years ago

GriffGreen commented 4 years ago

The dandelion deployment looks great! but i'm a little confused about this app and how to deploy it properly..

I don't really understand the purpose of the time lock app... it could use an explainer some where... Am I locking some tokens? what for? What address should i put in to this field?

The explainers don't make much sense without the context of what we are locking tokens for..

Screen Shot 2019-11-13 at 5 14 54 PM

and i hope this is a place holder ;-)

I am guessing, cause I have played the moloch game, that this is the functionality of 10 WETH for submitting a proposal... but if that is true, I only guessed it cause i have actually submitted proposals to moloch and had to pay it.

lkngtn commented 4 years ago

Perhaps adding a brief explanation of what the Time Lock apps purpose is above the configuration would help. Perhaps something along these lines:

The Time Lock app is used to discourage spammy, low-quality proposal submission by requiring users to lock tokens for a period of time whenever they submit a proposal. The amount and duration of each lock increases the more simultaneously active locks the user has accrued.

Do you think that would be sufficient contextual information to make the rest of the configuration more intuitive?

For the lock duration popup, agree that description is not ideal. How does the following sound:

Lock Duration determines the minimum amount of time the configured tokens must be locked in order to perform an action.

rperez89 commented 4 years ago
Screen Shot 2019-11-21 at 5 02 47 PM Screen Shot 2019-11-21 at 5 03 34 PM Screen Shot 2019-11-21 at 5 04 04 PM

@GriffGreen @lkngtn how do you feel with those changes now?

GriffGreen commented 4 years ago

This looks WAY better! I think I could understand it!

I assume the time lock app could be applied to many general applications and thats why it says "perform an action" instead of "submit a proposal to vote"

rperez89 commented 4 years ago

This looks WAY better! I think I could understand it!

I assume the time lock app could be applied to many general applications and thats why it says "perform an action" instead of "submit a proposal to vote" yeah, the idea is to also be able to use this app for any action that might require to lock some tokens

lkngtn commented 4 years ago

Not sure what happened to this, but it seems that this info component was removed from the onboarding at some point. We should put it back in.