search

1N3 / Sn1per

Attack Surface Management Platform
https://sn1persecurity.com
Other
7.93k stars 1.82k forks source link

Update install.sh #284

Closed gbiagomba closed 4 years ago

gbiagomba commented 4 years ago

added a conditional to check to see if the app being installed is already present, if it isnt the install command will run if not, it will pass it

1N3 commented 4 years ago

Nice one! I like the change.. might have to look at doing this for the plugins as well to cut down on upgrade time.

Anon-Exploiter commented 3 years ago

@1N3 did the changes merged of @gbiagomba were reverted? The latest install.sh doesn't have this in it.

Was that intended? Just curious.

gbiagomba commented 3 years ago

I didn't change anything i don't think

Anon-Exploiter commented 3 years ago

I didn't change anything I don't think

I'm talking about your two PRs, the one in which you compressed all the install commands in one line but now all the installation packages are again in different lines, and the second PR (this one) in which you added a check for binaries that already exist.

Due to some reason, I think the author reverted the changes, your commits/code isn't in the latest master branch.

gbiagomba commented 3 years ago

Alright, I submitted another request