Closed gbiagomba closed 2 years ago
Your code commit seems like a good optimization.. but damn you don't know how to open a good issue. By the first look of it I thought this was a shitpost.. Atleast write the changes done and some base details. Also would be better if that command line garbage is kept minimal..
Remember, KISS (Keep It Silly Simple). Probably the Sn1per devs see this as a shitpost from the longest terminal ourput garbage without any explanations of the error or what you fixed.. Sorry if this seems harsh but you gotta learn more kid.
Apologies for the delay... I ran into some issues trying to implement this into the install script where it seems to get stuck installing rubygems in an endless loop for some reason. It's also becoming difficult to keep things consistent between all the development branches for Sn1per now. For the time being, I'm going to leave the installer as is, but thank you for the PR. The idea is good but all use cases need to be worked out before I can push it to public.
Reading state information... Done
ruby is already the newest version (1:2.7+2).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'ruby' instead of 'rubygems'
ruby is already the newest version (1:2.7+2).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
nfs-common is already the newest version (1:1.3.4-6).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'ruby' instead of 'rubygems'
ruby is already the newest version (1:2.7+2).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
nfs-common is already the newest version (1:1.3.4-6).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'ruby' instead of 'rubygems'
ruby is already the newest version (1:2.7+2).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
nfs-common is already the newest version (1:1.3.4-6).
The following packages were automatically installed and are no longer required:
bundler golang-1.15 golang-1.15-doc golang-1.15-go golang-1.15-src john john-data libaio1 libc-devtools libgd3 libgmp-dev libgmpxx4ldbl libpcap0.8 nasm oracle-instantclient-basic postgresql ruby-bundler ruby-dev ruby2.7-dev ruby2.7-doc sudo
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 63 not upgraded.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'ruby' instead of 'rubygems'
ruby is already the newest version (1:2.7+2).
@xerohackcom thank you for the feedback - with that said, if you read my initial line I submitted a similar fix in the past but for reasons unknown
is there for a reason. @1N3 and I spoke before about this very script so I knew when he would see my name and what i gave he would know what I was referring too. Plus we had other discussions on other pull requests with some of the contributors regarding it. My initial commit had more detail, I was just bringing this back up to him with some added checks.
@1N3 Thank you for the update - if you dont mind my asking what system where you testing it on? I want to make sure I am not experiencing the same and if I do that I flush out all issues.
I submitted a similar fix in the past but for reasons unknown it didnt make it in this release. I did fix an issue that was in the last proposed fixed and i tested it to make sure it worked