Please add support for (anti)affinity for all deployments, etc

[lhriley]

Summary

Please include the option to define pod placement using affinity: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity

Use cases

We have specific node pools dedicated to different resource requirements, and we place our pods using node / pod affinity. This is much more flexible than using nodeSelector for our purposes.

Proposed solution

Change these (and any I missed):

https://github.com/1Password/connect-helm-charts/blob/54faa0ccffa9a09bc87b7e2ac8ba6904ec47a28f/charts/connect/templates/operator-deployment.yaml#L35-L40

https://github.com/1Password/connect-helm-charts/blob/54faa0ccffa9a09bc87b7e2ac8ba6904ec47a28f/charts/connect/templates/connect-deployment.yaml#L35-L38

to:

      {{- with .Values.<deployment>.nodeSelector }}
      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with .Values.<deployment>.affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with .Values.<deployment>.tolerations }}
      tolerations:
        {{- toYaml . | nindent 8 }}
      {{- end }}

Is there a workaround to accomplish this today?

n/a

References & Prior Work

• similar implementation from bitnami (they have several to choose from): https://github.com/bitnami/charts/blob/0a740aabf6eacd78075e53a74abdd562862f40b2/bitnami/external-dns/templates/dep-ds.yaml#L44-L51

[jillianwilson]

Hi there, I logged this internally to implement this. However, I can't give a timeline for when this can be completed. Please feel free to make a PR for this if you wish :)