1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

Wrongly generated serviceName when tls is enabled #140

Closed Altiire closed 1 year ago

Altiire commented 1 year ago

Your environment

Chart Version: latest

Helm Version: 3.11.2

Kubernetes Version: 1.25.4

What happened?

onepassword-connect-https service does not exist as the service template generate onepassword-connect service using http and https if tls is enabled

What did you expect to happen?

onepassword-connect service should be used by the ingress when tls is enabled

Steps to reproduce

  1. enable ingress and use the default values

Notes & Logs

jillianwilson commented 1 year ago

Thank you for raising this issue, we've noticed that you didn't sign your commits on your PR. We can sign it for you but would like to give you the chance to do so you remain the author of the pr