1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

Custom Environment Variable Support #182

Closed jillianwilson closed 9 months ago

jillianwilson commented 9 months ago

This MR aims to address #152 . Because there are many possible environment variables that users may want to add to their helm chart was decided to add the option to include custom environment variables to be added to the connect, injector, and operator containers.

This work can be tested using the following steps:

  1. Create a custom values file
  2. Add the following text:
    connect:
    customEnvVars:
    - name: "CUSTOM_ENV_VAR1"
      value: "customvar2"
    - name: "CUSTOM_ENV_VAR2"
      value: "customvar2"
  3. Run the following command:
    helm template -f newvalues.yaml connect ./connect
  4. Check that the new environment variables have been added to the connect container in the manifest. These steps should be followed for the injector and operator containers as well.