Ability to add additional labels to the connect serviceMonitor - Githubissues

1Password / connect-helm-charts

Official 1Password Helm Charts

https://developer.1password.com

MIT License

90 stars 73 forks source link

Ability to add additional labels to the connect serviceMonitor #195

Open jhoblitt opened 4 months ago

jhoblitt commented 4 months ago

Summary

PR https://github.com/1Password/connect-helm-charts/pull/151 introduced a serviceMonitor but did not include a parameter to add additional labels to the resource.

Use cases

In my environment, we use labels on serviceMonitors to control scraping.

Proposed solution

Add support for connect.serviceMonitor.additionalLabels as is commonly supported in other charts.

Is there a workaround to accomplish this today?

The only option today is to add labels to all connect resources via connect.labels.