search

1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

fix: credential secret does not works if set from values #196

Open grhawk opened 5 months ago

grhawk commented 5 months ago

Same as https://github.com/1Password/connect-helm-charts/pull/113 with verified commit.

jillianwilson commented 5 months ago

Hey @grhawk ! Thanks for creating the new PR! Looks like there are some merge conflicts here. Do you mind taking a look at those?

grhawk commented 5 months ago

@jillianwilson sorry, I don't remember out of my head what I did there since it is about 2y old and I don't have much time to re-look into it from scratch :)

stewartmalik commented 5 months ago

I'm actually not sure that this one is required, https://github.com/1Password/connect/issues/62 seems to suggest that connect requires the value to be doubly base64 encoded.

I have run the chart test suite successfully without these changes and everything worked as expected, I was able to retrieve my secret value.

grhawk commented 3 months ago

I think a doubly encoded secret looks more like a workaround than a solution and generates annoying effects. For example, all tools that allow to see secrets will not work properly since they expect the secret to be encoded only once.

grhawk commented 3 months ago

@jillianwilson I think you already fixed the conflicts in the previous MR. See https://github.com/1Password/connect-helm-charts/pull/113/commits/adcbeffe1efe540f5bbb61d11f9c458849a98681

smauermann commented 1 month ago

Bump, I would love for this to be merged. Without a fix to the double base64 encoding situation it is really hard bootstrapping onepassword connect in a GitOps environment. 🙏