Open craigmiller160 opened 3 months ago
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}
) and force push them to this branch (git push --force-with-lease
).
If you're new to commit signing, there are different ways to set it up:
gpg
ssh-agent
Hello. I opened this PR a significant amount of time ago. I just updated it with the latest changes from your main branch. I hope someone can get to reviewing it. Thank you.
I have signed all commits since the original warning
THE PROBLEM
The 1Password connect operator supports adding a TLS certificate for direct intra-cluster traffic (via its kubernetes service). In many cases, securing intra-cluster traffic with TLS (ie, a no-trust scenario) means assigning a certificate that is either self-signed or signed by an internal organization CA. In both cases, this then means that the 1Password operator needs to be able to trust this certificate.
In its current form, there is no way to configure the 1Password operator to trust a certificate from an unknown authority, which makes a no-trust secure internal network very difficult to construct.
MY SOLUTION
I have added a new optional values.yaml property,
operator.tls.trust.secret
. It should point to the same secret used to providetls.crt
to the connect application. If a user provides that value, the secret is mounted as a volume in the operator application, and the golang SSL_CERT_FILE environment variable is set. This results in the operator successfully trusting the certificate used by the connector.TESTING PERFORMED
I have deployed 1Password to my own kubernetes environment with the fork I made to perform this change, and I have validated that everything works end-to-end.
NEXT STEPS
I sincerely hope the 1Password team will review this contribution. Any changes you request I will be happy to perform. Thank you so very much.