search

1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

Please add a way to set imagePullSecrets to deployments #203

Closed remidebette closed 2 months ago

remidebette commented 3 months ago

Summary

Please add a way to set imagePullSecrets to deployments

Use cases

In busy kubernetes clusters, one can get rate limited to download images on dockerhub (like the default of this helm chart)

Proposed solution

Simply add a field in the values that would get injected in the deployment

volodymyrZotov commented 3 months ago

Thank you for raising this, @remidebette ! 🙏 The team is currently busy with other projects but will get back to it as soon as possible.

Meanwhile, you're very welcome to make your own PR with this improvement and we'll be very glad to review and merge it. Here is CONTRIBUTING.md file that might help to prepare the PR.

luflow commented 3 months ago

@remidebette We have the same issue :) Just invested some minutes to crate a MR for this

@volodymyrZotov Tell me if you need anything to bring this into the next release.

luflow commented 3 months ago

@volodymyrZotov PR pipelines look now good :)

Do you have a timeline when someone can take a look at the PR and publish a new version of the helm charts?