search

1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

feat: Adds possibility to set image pull secrets in all charts #204

Closed luflow closed 2 months ago

luflow commented 3 months ago

Adds possibility of image pull secrets to all charts

on connect: global on secrets injector: in the injector scope

closes #203

luflow commented 3 months ago

Also fixed some whitespace issues in the two templates I touched.

luflow commented 3 months ago

@edif2008 Fixed the linting errors

edif2008 commented 2 months ago

I've also noticed just now that your branch seems to be in conflict with the latest main. What I recommend is to update your branch with the latest main while you address the comments.

luflow commented 2 months ago

@edif2008 thx for your review, fixed all your comments :)

volodymyrZotov commented 2 months ago

Hi @luflow 👋. I merged another one PR https://github.com/1Password/connect-helm-charts/pull/170 earlier today, which caused the conflicts with your one 🤦‍♂️. I solved them, but looks like there is a protection rule on your forked repo, so I could not push the changes into your branch.

I'd appreciate if you have a chance resolve the conflicts once again. Or give us permission to push to your branch, so we can help you with that. And finally merge you PR 😃

Sorry for the inconvenience. I appreciate the efforts and the time you put into making this contribution! 👍

luflow commented 2 months ago

@edif2008 @volodymyrZotov Done :)

luflow commented 2 months ago

@edif2008 @volodymyrZotov anything else needed? :) Looking forward to the merge 🤩