1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

Watch all namespaces for secrets (attempt 2) #69

Closed Gibstick closed 3 years ago

Gibstick commented 3 years ago

I needed this for something I was working on, but I noticed #62 was kinda stalled. Thanks to @rchenzheng for doing all of the hard work. This PR addresses the comments in #62.

This change creates a ClusterRoleBinding conditionally if all namespaces are to be watched. By default, all namespaces are watched, to match the default behaviour when deploying the operator. This behaviour can be explicitly opted into by specifying an empty list for operator.watchNamespace.

See also:

54

https://github.com/1Password/onepassword-operator/pull/40