search

1Password / connect-helm-charts

Official 1Password Helm Charts
https://developer.1password.com
MIT License
93 stars 74 forks source link

Passing credentials via credentials_base64 breaks the installation #94

Open azerbe opened 2 years ago

azerbe commented 2 years ago

Your environment

Chart Version: 1.7.1

Helm Version: 3.8.1

Kubernetes Version: v1.23.4

What happened?

I am using the op cli tool to get the credentials.json from a 1Password vault and register it to an ansible variable. Then I'm base64 encoding the json and pass it to the helm-charts connect.credentials_base64 value.

Because of the stringData: type in the secret, the base64 value gets encoded again.

What did you expect to happen?

If a _base64 variable is provided, then it should be able to take values without using --set-file flags. This would make it compatible with different scenarios, where you don't want to store the credentials json in an actual file or retrieve it from a script.

Steps to reproduce

  1. Pass a base64 encoded credentials.json string to the connect.credentials_base64 value
jillianwilson commented 2 years ago

Hi there, thanks for raising this issue. I can certainly see this being problematic for certain use cases. We will look into providing a good solution for this.

volodymyrZotov commented 5 months ago

Should be solved in #196