1Password / connect-sdk-python

Python SDK for 1Password Connect
https://developer.1password.com/docs/connect
MIT License
200 stars 30 forks source link

Get Items do not work with svc account auth #109

Closed deLimaNicolas closed 3 months ago

deLimaNicolas commented 3 months ago

Your environment

SDK Version: 1.0.7

OS: Ubuntu 20.04

Python Version: 3.1

What happened?

Basically if I'm not mistaken, this SDK is nothing but another layer of abstraction on top of the op cli.

And if you're using the op cli and tries to get an Item when running the authentication with a svc account you will receive this:

Screenshot 2024-05-16 at 17 33 39

In short, you need to specify the vault whenever trying to get an item. And the problem is that, although we're able to do it using the cli, the sdk get_item method does not have a way to inform the vault.

What did you expect to happen?

Maybe having a vault optional param? something like:

Screenshot 2024-05-16 at 19 38 05

Steps to reproduce

  1. Auth using a service account
  2. Try to get an item using the sdk