search

1Password / connect-sdk-python

Python SDK for 1Password Connect
https://developer.1password.com/docs/connect
MIT License
200 stars 31 forks source link

Fix readme `load` and `load_dict` example #37

Closed Marton6 closed 2 years ago

Marton6 commented 2 years ago

The first parameter was missing in the example from the README.

Resolves: https://github.com/1Password/connect-sdk-python/issues/35

codecov-commenter commented 2 years ago

Codecov Report

Merging #37 (e50a063) into main (678d607) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   76.08%   76.08%           
=======================================
  Files          21       21           
  Lines        1597     1597           
=======================================
  Hits         1215     1215           
  Misses        382      382

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 678d607...e50a063. Read the comment docs.

edif2008 commented 2 years ago

Could we further expand this PR (or make a new one) which fixes the example for load as well? It's the same issue (i.e. the client parameter is not mentioned, although it's needed)

Marton6 commented 2 years ago

Could we further expand this PR (or make a new one) which fixes the example for load as well? It's the same issue (i.e. the client parameter is not mentioned, although it's needed)

Done!