1Password / connect-sdk-python

Python SDK for 1Password Connect
https://developer.1password.com/docs/connect
MIT License
200 stars 31 forks source link

SSH_KEY is an invalid value for 'category' #53

Closed floriandaniel closed 1 year ago

floriandaniel commented 1 year ago

Hello ! I'm trying to get an SSH key from 1Password Connect Server with the API. But I'm getting the following issue :

ValueError: Invalid value for `category` (SSH_KEY), must be one of ['LOGIN', 'PASSWORD', 'SERVER', 'DATABASE', 'CREDIT_CARD', 'MEMBERSHIP', 'PASSPORT', 'SOFTWARE_LICENSE', 'OUTDOOR_LICENSE', 'SECURE_NOTE', 'WIRELESS_ROUTER', 'BANK_ACCOUNT', 'DRIVER_LICENSE', 'IDENTITY', 'REWARD_PROGRAM', 'DOCUMENT', 'EMAIL_ACCOUNT', 'SOCIAL_SECURITY_NUMBER', 'API_CREDENTIAL', 'CUSTOM']

Do I only need to submit a new PR ? including the new category type "SSH_KEY"

ftasbasi commented 1 year ago

try with latest version, i was getting same error with version 1.2.0 and it's solved whenever I used 1.3.0.

edif2008 commented 1 year ago

Hey @floriandaniel, As @ftasbasi suggested, updating the Connect Python SDK to the latest version (1.3.0) should address the issue you're running to. That release contains https://github.com/1Password/connect-sdk-python/pull/54, which solves the unexpected error for new categories that are added to Connect.

Closing the issue for now. Feel free to re-open if you still run into this issue with the latest version of the SDK.