1Password / connect-sdk-python

Python SDK for 1Password Connect
https://developer.1password.com/docs/connect
MIT License
200 stars 31 forks source link

SDK to support async operations #58

Closed HaddadJoe closed 1 year ago

HaddadJoe commented 1 year ago

Summary

When downloading a bunch of items to initialize our app, we would like to benefit from async io operation to perform multiple bulk downloads. Current implementation force us to download these sequentially or having to resort to using threading which create a large overhead.

Use cases

Initializing an app on runtime to download all needed passwords

Proposed solution

Implement the internal request builder using built-in async.io or any other async library

Is there a workaround to accomplish this today?

yes, running using threads

References & Prior Work

no sure

HaddadJoe commented 1 year ago

hey @volodymyrZotov what's the situation on that ?

volodymyrZotov commented 1 year ago

Hi @HaddadJoe. Thank you for raising this feature request! Sorry for a such a delay with that. This is still on our team's radar. I'll try to come back on it as soon as possible, address all the PR comments and bring it into a good shape soon.

HaddadJoe commented 1 year ago

hey @volodymyrZotov just checking back on this please. Do you need help on this PR? Any expected date for the release?

volodymyrZotov commented 1 year ago

Hi @HaddadJoe . I expect to make a release with that by the end of the week.

HaddadJoe commented 1 year ago

amazing, ready to test here and give you some feedback

volodymyrZotov commented 1 year ago

That would be great, thanks @HaddadJoe !