Closed volodymyrZotov closed 1 year ago
Base: 76.29% // Head: 76.11% // Decreases project coverage by -0.17%
:warning:
Coverage data is based on head (
3a3ddb6
) compared to base (5e70b02
). Patch coverage: 14.28% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This looks good to me. A couple of questions before approving this PR:
0.17%
), but would like to know the reason for it.Also, one small notice. Since you've removed the six
dependency in a couple of files, now we have two new lines between the imports and the code itself. I believe having only one is enough, so you can remove the extra newline as well.
@edif2008 Thank you for reviewing!
And regarding the code formatting.
Pycharm suggest to use new 2 lines between imports section and the rest of the code PEP 8: E302 expected 2 blank lines, found 1
. I'd stick with 2, as it was before the changes also.
Users ask to get rid of python2 support as it is not possible for them to use this Connect client in new projects.
The changes are done in PR:
six
package.The package is functionally tested. No issues were found after applying the changes.
Resolves #59