search

1Password / connect

Access your 1Password secrets using a 1Password Connect Server
https://developer.1password.com/docs/connect
152 stars 29 forks source link

Added ports back to the Connect Sync container #51

Open erik-pineiro-github opened 2 years ago

erik-pineiro-github commented 2 years ago

After confirming with @edif2008, the Connect Sync container should also have ports mapped per the example found in the developer documentation.

ag-adampike commented 2 years ago

Hey @erik-pineiro-github, thanks for filing the PR. In my mind we should attack this by linking the example file in the documentation to this GitHub repository rather than changing the port designation here.

Just to clarify, why is this port needing to be exposed on the Docker host? The connect-sync container is responsible for connecting to 1Password.com to sync vault data, and should not require any ingress whatsoever.