1Password / connect

Access your 1Password secrets using a 1Password Connect Server
https://developer.1password.com/docs/connect
149 stars 28 forks source link

Push images to a different registry, in addition to Docker Hub #56

Open onedr0p opened 1 year ago

onedr0p commented 1 year ago

Is your feature request related to a problem? Please describe.

In order to combat dockerhub's imposed rate limits it would be great to host these images on ghcr or quay.io.

Describe the solution you'd like

Push the connect-api and connect-sync images to an additional container registry like Quay or GHCR.

There is nothing like your Kubernetes cluster not able to use secrets because dockerhubs very low pull rate limits.

onedr0p commented 1 year ago

Given the recent dockerhub announcement of removing free team orgs, I'm wondering if the current 1password org will be affected? And if so perhaps this could finally have a high priority?

https://github.com/docker/hub-feedback/issues/2314

onedr0p commented 1 year ago

@jpcoenen sorry, not to poke too much but according to Docker you have until April 15th to either pay Docker for keeping your Org or migrate the container elsewhere.

onedr0p commented 1 year ago

@ag-adampike @scottisloud anyone?

jpcoenen commented 1 year ago

Hey @onedr0p,

Let me start by addressing the most urgent matter: first we should not be affected by Docker's recent announcement. 1Password is on a paid Docker subscription.

With regards to your suggestion to pushing to a different image repository: I'll bring that up with my team. I do see the convenience of having more lenient/no rate limits on pulls.

Out of curiosity: have you ever run into these rate limits by pulling Connect? Because I'd expect the images to live in k8s image store after a pull. However, if something is preventing that, we should look into that as well.

Cheers, Joris

onedr0p commented 1 year ago

@jpcoenen thanks for confirming that the 1Password Dockerhub org is not going to be affected. Dockerhub doesn't provide any information on wether or not certain Dockerhub Orgs are going to be affected or not.

The only thing we see is this:

image

Out of curiosity: have you ever run into these rate limits by pulling Connect? Because I'd expect the images to live in k8s image store after a pull.

I have not tested 1Password per-say but it can be a fairly common issue when your team is bootstraping Kubernetes clusters and it needs to pull a bunch of fresh images.