search

1Password / connect

Access your 1Password secrets using a 1Password Connect Server
https://developer.1password.com/docs/connect
152 stars 29 forks source link

Memory Leak in Connect API Container #64

Open mega-nick opened 1 year ago

mega-nick commented 1 year ago

Your environment

Chart Version: connect-1.10.0 Image version: 1password/connect-api:1.6.1 Helm Version: 3.11.1 Kubernetes Version: v1.24.9-gke.3200

What happened?

I found that the onepassword-connect pod was using a great deal of memory, specifically the connect-api container. The connect-api container was upgraded to the latest version, 1.6.1, and there still seems to be a pretty obvious memory leak.

Steps to reproduce

Deploy the 1Password Connect Helm chart on Kubernetes View pod memory metrics within an hour or two

Notes & Logs

image image

max(container_memory_working_set_bytes{container="connect-api", pod="YOUR-POD-NAME"} / (1024*1024)) by (container)

baryluk commented 1 year ago

Yes, it is leaking A LOT

It is bad:

image

We are sending maybe 5 requests per minute to it. (Mostly continuous, 24/7)

jillianwilson commented 1 year ago

Thank you for reporting this, I appreciate all the detailed information. I'll share with with the team for further investigation

tomjohnburton commented 1 year ago

This is a duplicate of #23 This is crazy that it's still not solved... What is the point of having open source code if you don't maintain it?

antoineco commented 1 year ago

The report is for v1.6.1, but as of v1.7.0 this issue still exists, despite the changelog indicating otherwise.

In a very much idle cluster (4 secrets):

leak