1Password / install-cli-action

Install 1Password CLI into your GitHub Actions jobs.
https://developer.1password.com
MIT License
36 stars 12 forks source link

Add support for windows runner #4

Open szzsolt opened 11 months ago

szzsolt commented 11 months ago

This PR adds support for running the action on windows runners. It includes:

edif2008 commented 11 months ago

It looks like your commits are not signed. A requirement of this repo is to have the commits signed.

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with `gpg`: 1. [Generate a GPG key](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key) 2. [Add the GPG key to your GitHub account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account) 3. [Configure `git` to use your GPG key for commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-gpg-key)
Sign commits with ssh-agent

Follow the steps below to set up commit signing with `ssh-agent`: 1. [Generate an SSH key and add it to `ssh-agent`](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent) 2. [Add the SSH key to your GitHub account](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account) 3. [Configure `git` to use your SSH key for commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key#telling-git-about-your-ssh-key)
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process. Learn how to [use 1Password to sign your commits](https://developer.1password.com/docs/ssh/git-commit-signing/). Watch the demo
edif2008 commented 11 months ago

This is really exciting to see! Thank you so much for contributing with this enhancement! 💪🏻

Jongveloper commented 10 months ago

@edif2008 @szzsolt I need to run actions on the window as soon as possible. So, can I copy the contents of the PR and sign the commitment to post the PR?😢😢

Natiq0 commented 4 months ago

+1

@szzsolt Any chance you will sign your commits?

@Jongveloper Did you manage to find a workaround? Did you re-post the PR with signed commits?