1Password / kubernetes-secrets-injector

MIT License
53 stars 7 forks source link

Pass User-Agent info to container that has the CLI in it #2

Closed edif2008 closed 2 years ago

jillianwilson commented 2 years ago

Have you tested this locally?

edif2008 commented 2 years ago

The injector itself needs the following updates:

The working injector can be found in the test-env-inject branch.

I have tested the working version of the injector and indeed in the response it passes the User-Agent info required for the CLI.

edif2008 commented 2 years ago

@jillianwilson The updates for the injector to work are in this PR: https://github.com/1Password/kubernetes-secret-injector/pull/5

Note that the updates don't include the certificate management. That is still work in progress. However, these are valid and shouldn't depend on the certificate management part.

jillianwilson commented 2 years ago

As long as this has been tested and verified to work I am happy with this :)