search

1Password / kubernetes-secrets-injector

MIT License
53 stars 7 forks source link

Make webhook config on the fly #7

Closed edif2008 closed 2 years ago

edif2008 commented 2 years ago

This PR enables the webhook deployment do generate the certificate on the fly.

This simplifies the webhook's deployment process. All the user has to do is to deploy the 3 yaml files in the deploy directory.

Work for this PR is heavily inspired from this repo: https://github.com/morvencao/kube-sidecar-injector

jillianwilson commented 2 years ago

Looks good overall,

Quick question: are there any configurations we want to allow users to make to the certificate?

volodymyrZotov commented 2 years ago

@jillianwilson That might be something we want to add. Let's discuss this internally.