1Password / load-secrets-action

Load secrets from 1Password into your GitHub Actions jobs
https://developer.1password.com
MIT License
190 stars 25 forks source link

load-secrets-action doesn't work on windows #46

Open Xuanwo opened 1 year ago

Xuanwo commented 1 year ago

Background

OpenDAL adopts load-secrets-action to manage all secrets. We are trying to load secrets to build our artifacts on linux/macos/windows platform. Java maven will use thoes secrets to sign the packages.

Expected

Secrets loaded as on linux platform.

Actual

Meeting errors like the following:

Run 1password/load-secrets-action@v1
"C:\Program Files\Git\bin\sh.exe" -c D:\a\_actions\1password\load-secrets-action\v1/entrypoint.sh
/usr/bin/bash: line 1: D:a_actions1passwordload-secrets-actionv1/entrypoint.sh: No such file or directory
Error: The process 'C:\Program Files\Git\bin\sh.exe' failed with exit code 127

See action at: https://github.com/apache/incubator-opendal/actions/runs/5367357180/jobs/9737444126?pr=2525

edif2008 commented 1 year ago

Hey there. Currently this GitHub Action is not supported on Windows.

Thank you for sharing that you'd like to see this work on Windows as well. We will keep you updated when there's any progress on this.

martincostello commented 1 year ago

+1 - it is poor that this wasn’t designed to be cross-platform from the start.

I was interested in adopting this action, but I validate cross-platform compatibility of my code on Linux, macOS and Windows, which makes this action unusable for my purposes as it isn’t a drop-in replacement for native GitHub secrets.

nikolamilekic commented 1 year ago

+1 Are there any plans to fix this? Thanks!

itachenko commented 11 months ago

Hey guys, any ETA when this gonna be fixed?

shyim commented 10 months ago

Maybe an alternative for some https://github.com/shyim/1password-load-secrets-action

mikeclayton commented 3 months ago

We adopted 1password for enterprise about a year ago and we're gradually integrating it into our GitHub Actions workflows - it's been fine for dotnet / Linux builds but we've started trying to cut over some of our older .Net Framework legacy apps that only build on Windows Runners, and this is now a blocker.

I actually spent a fair bit of time trying to get the action working thinking I was doing something wrong, before I even considered that it might not be supported (see https://1password.community/discussion/comment/712388).

We really only want to have one way of managing secrets and 1Password has been a great fit so far, but it looks like we're going to have to fall back to GitHub Actions Secrets for Windows Runner builds which is going to be miserable...

This seems like such an obvious gap - can we get an update on whether it's even on the roadmap and / or a timescale?

Jonathan-Zollinger commented 1 month ago

any chance this is going to be mitigated? I'd love to include it in my graal compiling runners for windows builds.

rfay commented 3 weeks ago

This was an unpleasant surprise :(