search

1Password / load-secrets-action

Load secrets from 1Password into your GitHub Actions jobs
https://developer.1password.com
MIT License
195 stars 26 forks source link

Node.js 16 deprecation warning when using action #61

Closed parente closed 7 months ago

parente commented 9 months ago

GitHub deprecated Node.js v16 use in September 2023. The blog post mentioned in the deprecation warning suggests they'll remove node 16 entirely in Spring 2024.

Using the action like so on 2023-01-22 (when the v1 tag is pointing to v1.3.1):

- name: Export 1Password secrets
  uses: 1password/load-secrets-action@v1
  with:
    export-env: true
  env:
    REDACTED: ...

results in the following deprecation warning in the GitHub Actions workflow summary:

Node.js 16 actions are deprecated. Please update the following actions to use 
Node.js 20: 1password/load-secrets-action@v1. For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
deon-vector commented 9 months ago

Confirmed, I'm using 1.3.1 (latest) and still see the Node.js 16 deprecation warning.

nick-fields commented 9 months ago

Same here

grant commented 9 months ago

Someone want to bump the version?

https://github.com/1Password/load-secrets-action/blob/c7a1c1e3bb7a538901cb8c861b84aa52176287cc/action.yml#L15

dustin-ruetz commented 8 months ago

Hi everyone 👋 Thank you for your patience on this issue, and thanks @parente for flagging this Node.js v16 deprecation warning and putting up a PR.

Replying here to confirm that we're aware of this issue and that we'll be addressing it soon in an upcoming release of load-secrets-action.

deon-vector commented 8 months ago

@dustin-ruetz it's been 3 weeks since your comment and we haven't heard anything about an upcoming release. parente's PR is a month old and would have solved this annoying deprecation warning but it hasn't been approved/merged yet. What's the latest info?