1Password / load-secrets-action

Load secrets from 1Password into your GitHub Actions jobs
https://developer.1password.com
MIT License
190 stars 25 forks source link

export-env security risk #79

Open datbth opened 1 week ago

datbth commented 1 week ago

Currently, export-env has a default value of true and is also suggested to be set as true in README.

While it is convenient to do so, it makes the secrets available as ENVs to all the later steps, including the third-party GitHub Actions. This can easily lead to leaking secrets when using malicious or vulnerable GitHub actions.
Thus, I think it should at least be mentioned in README.

Additionally, the usage of the step outputs of load-secrets-action should also be documented.