search

1Password / onepassword-sdk-js

The official JavaScript SDK for 1Password
https://developer.1password.com/docs/sdks/
MIT License
37 stars 3 forks source link

Use a new secret in CI and update the secret reference #11

Closed AndyTitu closed 5 months ago

AndyTitu commented 5 months ago

According to our internal guidelines for using SA tokens in CI, I changed the Github secret to SA token from our shared b5test account. For tests to still pass I needed to update the secret references.

Marton6 commented 5 months ago

@AndyTitu why did you have to retry the pipeline? Have you determined what caused the pipeline failure from before?

AndyTitu commented 5 months ago

why did you have to retry the pipeline? Have you determined what caused the pipeline failure from before? @Marton6 I got an "authentication error" in the pipeline initially when using the new service account token. I used the token from the CLI once and now the error disappeared. I did not pinpoint the exact issue since I will need a closer look at the scenario using some more descriptive sdk-core erroring.

I found an issue about improving erroring in sdk-core and I added an extra acceptance criteria about this specific improvement: https://gitlab.1password.io/dev/sdk/sdk-core/-/issues/23