search

1Password / onepassword-sdk-js

The official JavaScript SDK for 1Password
https://developer.1password.com/docs/sdks/
MIT License
37 stars 3 forks source link

Prepare for code generation by moving generated code to separate files #15

Closed sam-1pass closed 4 months ago

sam-1pass commented 5 months ago

Move all constant code to client_util.ts and leave only generated code in client.ts in preparation for automating code generation.

Marton6 commented 5 months ago

This looks good so far! Can you resolve the merge conflicts on it and give the MR a more descriptive title and description, @sam-1pass?

The description could mention why we're doing this: in preparation for automating code generation.

Marton6 commented 4 months ago

@sam-1pass I improved the title a bit more to also express the intent behind the change. This makes it easier to understand why we made this change when we read the PR title