fix: revoke user from group

1Password / op-js

A JS library powered by the 1Password CLI

https://developer.1password.com/docs/cli

MIT License

91 stars 8 forks source link

fix: revoke user from group #170

Closed tonymilne closed 3 months ago

tonymilne commented 10 months ago

Fixes a bug that prevents revoking a user's membership from a group.

Currently the command incorrectly calls grant (without a role parameter), which results in them being updated to the default member role of that group.

jodyheavener commented 9 months ago

Hey @tonymilne! Whoops, this is a great catch. I'm happy to merge, however Git commits to this repo's main branch need to be signed. Would you able to sign your commit? If you're new to commit signing, 1Password has a solution for that! 😄

jodyheavener commented 3 months ago

Merged in https://github.com/1Password/op-js/commit/5aa2b2bbdef10beb3309a3314ba4d69d39684e6e