1Password / passkey-rs

A framework for defining Webauthn Authenticators that support passkeys
Apache License 2.0
116 stars 17 forks source link

Add support for incremental counters #23

Closed coroiu closed 2 months ago

coroiu commented 3 months ago

This PR should be merged after https://github.com/1Password/passkey-rs/pull/22

While passkey-rs does support saving counters, they are completely ignored in the authenticator algorithm.

This PR adds support for them by adding a configuration flag to enable/disable counters, and then also add support for detecting when we are forced to use a counter (the user picks a credential with a non-zero counter). This is needed when we don't necessarily want to create new credentials with counters, but the library was provided with a credential that already has one.


Bitwarden internal tracking: [PM-8571] based on [PM-7144]