search

1Password / passkey-rs

A framework for defining Webauthn Authenticators that support passkeys
Apache License 2.0
116 stars 17 forks source link

Upgrade p256 from v0.10 => v0.13. #4

Closed RobbieMcKinstry closed 9 months ago

RobbieMcKinstry commented 12 months ago

This PR upgrades the version of p256, and addresses the breaking changes introduced by this upgrade. Upgrading this dependency allows passkey-rs to transitively install newer versions of the signature crate. The version of signature required by p256@v0.10 is incompatible with other cryptography crates in the ecosystem.

Closes https://github.com/1Password/passkey-rs/issues/3

FWIW, I'm happy to address any style changes you might prefer. I didn't put much thought into variable naming; I just made the minimum changes. Happy to improve the code quality at the request of reviewers. ^.^

hariria commented 9 months ago

Could the signature crate also be updated per-chance?

Progdrasil commented 9 months ago

I'm at the point of being able to merge this PR. Thank you for the contribution and your patience!

RobbieMcKinstry commented 9 months ago

No problem! Thanks for merging, and for updating the signature crate.