Closed RobbieMcKinstry closed 9 months ago
Could the signature crate also be updated per-chance?
I'm at the point of being able to merge this PR. Thank you for the contribution and your patience!
No problem! Thanks for merging, and for updating the signature
crate.
This PR upgrades the version of
p256
, and addresses the breaking changes introduced by this upgrade. Upgrading this dependency allowspasskey-rs
to transitively install newer versions of thesignature
crate. The version ofsignature
required by p256@v0.10 is incompatible with other cryptography crates in the ecosystem.Closes https://github.com/1Password/passkey-rs/issues/3
FWIW, I'm happy to address any style changes you might prefer. I didn't put much thought into variable naming; I just made the minimum changes. Happy to improve the code quality at the request of reviewers. ^.^