Open ag-adampike opened 2 years ago
I agree with him. AWS Terraform Example is so poor and need to upgrade.
We seem to be hitting the first issue listed here - we get the following error:
creating ELBv2 application Load Balancer (xxx-alb): ValidationError: At least two subnets in two different Availability Zones must be specified
How do we go about specifying subnets - there doesn't seem to be anywhere to provide this information? Also, some guidance on creating a dedicated VPC and subnets would be great.
The example seems to assume a lot of knowledge of AWS and Terraform, which is not necessarily the case for a 1Password/IAM admin.
Hey @mikedowler. I'm sorry I missed your comment here.
For using an existing, non-default VPC, you can specify the subnets to use by tagging them with a key of SubnetTier
and a value of public
. This line in the Terraform script selects the subnets with this tag:
You might also consider using our CloudFormation template which requires no interaction with Terraform, can be deployed using the console, and creates a dedicated VPC and subnets for you: https://github.com/1Password/scim-examples/tree/main/beta/aws-ecsfargate-cfn
Hey!
I think the steps outlined here are missing some crucial step(s), namely, is this an official module to install?
https://github.com/1Password/scim-examples/blob/main/aws-ecsfargate-terraform/README.md
Hi Peter, the only dependencies here are Terraform/Terraform CLI, and the official AWS Terraform provider.
But let me know if I'm not interpreting your question correctly!
Hey Scott, thanks for the reply.
I think this deserves a terraform module in the terraform registry. Makes things easier for me and (admittedly) I am not a big fan of copying terraform files from repos 😅 which may change.
It's very much done with some tweaks and separating the whole Google Workspace stuff out.
This issue is to track a few fairly minor issues with our AWS Terraform deployment example:
provider
block (see https://www.hashicorp.com/blog/default-tags-in-the-terraform-aws-provider) rather than sprinkled throughout.aws_alb
is known asaws_lb
: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb)Some nice-to-haves, possibly for future work: