Closed scottisloud closed 2 years ago
closes #204
Integrated and tested Pike's suggestions and updated the readme with a brief note about potential ignorable errors a person may get when storing their workspace json files in the same directory as the deployment.
Apparently Git wasn't signing my commits 😫 Working on figuring out why that's the case.
Phew, after a harrowing rebase I've managed to get all previous commits signed.
Successfully tested K8 deployment with workspace-settings and workspace-credentials supplied as K8 secrets, as well as non GW bridge deployment.
Previously, the Kubernetes example walked people through the process of creating secrets for Google Workspace credentials, but those secrets were never mounted or used in the deployment. This PR fixes the deployment to support providing Google Workspace credentials at deployment time. It also accommodates a situation in which someone wants to update en existing bridge with Workspace credentials.
The deployment now correctly mounts workspace secrets if they are created.
volumeMounts
andvolumes
in op-scim-deployment to use a projected volume to accommodate multiple secrets.kubectl create secret
command to include a key value for Workspace secrets, in line with what has been done for thescimession
secret previously, to avoid naming discrepancies.In my testing, this deployment will work with or without Workspace credentials. It also works to update an existing bridge to have Workspace credentials (an unlikely scenario but 🤷♂️ ).