1Password / scim-examples

1Password SCIM Bridge deployment examples
https://support.1password.com/scim/
MIT License
148 stars 141 forks source link

Stop YOLO development in the helm chart. #244

Closed gothrek22 closed 1 year ago

gothrek22 commented 1 year ago

Hi,

It seems that the helm chart provided by 1Password has met some growing pains as part of it's development.

There is no proper changelog, default value changes and other random issues related to a disconnect between the chart and the bridge itself. Here's a related issue in that repo

Our bridge has been down for the whole day due to an issue after upgrading to the latest version of the chart. We've been able to fix it only after setting the following in the chart:

Only after setting the above and updating the key paths that changed were we able to have a functioning bridge.

I've raised a couple of issues in that repo, but it seems that it's not really a priority, I've also tried contacting support with no luck.

Hope this raises awareness about this issue.

grellyd commented 1 year ago

Hi @gothrek22,

Thank you for expressing your thoughts and concerns.

As the 1Password SCIM helm chart matures, we have indeed experienced some growing pains. Up to this point, the Helm chart has mostly existed as a method of distributing nearly identical kubernetes deployment to our 1-Click applications in the Google Cloud and Digital Ocean marketplaces. Bluntly, we err'd in marking the helm chart as version 2.x.x, which at the time seemed a natural extension after the helm chart had to diverge from 1Password SCIM bridge versions. A more appropriate version would have been 0.x.x given the developmental and fast changing nature of this chart.

No matter the reasons, having your deployment break on an upgrade sucks. I apologise for our choices that caused you have such a terrible experience.

With that in mind, here is what we are going to do going forward:

I hope that addresses your concerns. I look forward to your thoughts.

Graham

gothrek22 commented 1 year ago

@grellyd lovely, Thank you Graham, this is what I wanted to hear.

grellyd commented 1 year ago

Following up, these changes have been made in the op-scim-helm repo. The documentation still needs some improvement, but we have introduced proper release changelogs (https://github.com/1Password/op-scim-helm/releases) and are paying much closer attention to versioning. In addition we've made a few internal process changes to ensure these changes persist.

Screenshot 2023-08-21 at 2 45 44 PM