1Password / scim-examples

1Password SCIM Bridge deployment examples
https://support.1password.com/scim/
MIT License
147 stars 137 forks source link

Adding documentation for new Redis configuration variables #279

Closed scottisloud closed 8 months ago

scottisloud commented 9 months ago

This PR resolves issue #278 .

The introduction of these new environment variables in #276 and their documentation in this PR, provide customers with more flexible options for custom redis implementations, especially around handling authenticated redis connections.

scottisloud commented 9 months ago

I think I've done a preliminary update to the requisite README files and .env for all the deployments except:

scottisloud commented 8 months ago

I've added documentation for the new environment variables in all READMEs where relevant, and provided commented-out variables in configuration files where appropriate (e.g., not currently possible in Cloud formation, either not possible or deeply unlikely in DO and Container Apps).

Largely looking for scrutiny on the clarity of the copywriting and accuracy of the examples. Also open to suggestions if you have different ideas for including commented-out values in config files (if they should be there at all).

scottisloud commented 8 months ago

Added defaults and improved some of the language. Resolved an issue where one of the environment variable names was incorrect.