search

1Password / scim-examples

1Password SCIM Bridge deployment examples
https://support.1password.com/scim/
MIT License
147 stars 137 forks source link

Replace deprecated aws_subnet_ids data source in aws-ecsfargate-terraform example #284

Closed mmanjos closed 7 months ago

mmanjos commented 8 months ago

Terraform has deprecated aws_subnet_ids as of provider v4.0.0, which prevented the ecsfargate terraform example from provisioning.

The proposed changes on this PR have unblocked my particular rollout of the 1Password SCIM connector in AWS but please note: I have not tested all the possible ways that this change might affect other deployments.

plttn commented 8 months ago

Hey @mmanjos!

Thanks for flagging this. I've done a bit of investigation on this, and it looks like there are some additional minor changes needed here to bring the provider version up to 4 or 5. I've added this to my to-do list to be chatted about internally. Keep an eye out for updates!

mmanjos commented 8 months ago

@plttn Thanks! We've just started deploying 1Password SCIM Bridge at my org and this got us up and running - glad to help in any way possible.

plttn commented 7 months ago

@mmanjos: Thanks again for bringing this up, I've added you as a co-author on the commit that brought this fix in. 😃