search

1Password / shell-plugins

Seamless authentication for every tool in your terminal.
https://developer.1password.com/docs/cli/shell-plugins/
MIT License
526 stars 172 forks source link

1password wrapper breaks some of the ngrok cli commands that do not require authtoken #185

Open russorat opened 1 year ago

russorat commented 1 year ago

Platform or tool

ngrok

Desired or expected behavior

i would like to be able to run ngrok config edit without my terminal crashing.

Current behavior

after installing the ngrok plugin, when i run ngrok config edit, i am prompted for my 1password login, and then to select the credentials to use for this command. But this command doesn't need any credentials to run, so this is unnecessary.

after selecting the correct ngrok credentials, the shell just hangs with an empty screen. hitting ctl+c has no effect.

image

Relevant log output

i am using iterm 3.4.19, running ngrok agent 3.1.1, on MacOS 13.2.1 (22D68)

op CLI version

2.14.0

arunsathiya commented 1 year ago

Thanks for flagging this, @russorat! This is my fault and a PR to fix this is ready:

arunsathiya commented 1 year ago

I believe this should be resolved as of @AndyTitu's work in https://github.com/1Password/shell-plugins/pull/194, and we are also nearly about to switch to envvars for provisioning credentials: https://github.com/1Password/shell-plugins/pull/222