search

1Password / shell-plugins

Seamless authentication for every tool in your terminal.
https://developer.1password.com/docs/cli/shell-plugins/
MIT License
526 stars 172 forks source link

Update GitHub shell plugin to import credentials from encrypted system storages like MacOS Keychain #305

Open arunsathiya opened 1 year ago

arunsathiya commented 1 year ago

Platform or tool

GitHub

Desired or expected behavior

GitHub CLI should store the access token in ~/.config/gh/hosts.yml from where the GitHub shell plugin can import the credential into 1Password.

Current behavior

GitHub does not not seem to be storing the access token locally on that file at the moment.

Relevant log output

No response

op CLI version

2.19.0-beta.01

arunsathiya commented 1 year ago

I am still researching why this is happening and if this is an intentional change by gh CLI, but I wanted to log this here so that we can track and modify our importer as necessary.

arunsathiya commented 1 year ago

It seems that GitHub CLI starting late Feb/early March started using Mac keychain/secure storage as the default place auth token storage:

We'll need to build support for keychain-stored creds. The only shell plugin that I know of that supports importing of encrypted storage-stored creds is AWS, using aws-vault.

There's another request for importing Supabase credentials from the secure storage as well: