Open priscilasolis opened 1 year ago
Hey @priscilasolis! 👋🏻
Thank you for making this contribution and apologies for the late response.
I wanted to bring to your attention that we've recently migrated to the new terraform-plugin-framework. With this big change, this PR is no longer applicable to the latest version of the provider.
We really appreciate the time and effort that you have already put into this PR. If you have some additional time to spare and you're still interested in having this change applied, please go ahead and modify this PR to make it compatible with the latest v2 version of this provider, at which point we'd be happy to review it again.
I've also noticed that your commits are not signed. This repository requires all commits to be signed. If you work on changing this PR to make it compatible with the latest v2 version of the provider, it would be great to have your commits signed as well.
Here is some guidelines in achieving this.
ssh-agent
gpg
Resolves: #17
Description: There is currently no ability to add custom fields outside of a section with the 1Password Terraform provider.
Solution: A list of fields can now be defined outside of a section. Applying this is similar to how we currently implement fields inside a section.
It's important to note that in order to make this happen some other updates had to take place:
secure_note
category is added because there was no way to add fields without a password (also referenced in #66).note_value
in the resource as it was previously set in the data source.purpose
value from from the fields as it can cause a collision with thenote_value
argument whenNOTES
is set as the purpose.terraform apply
.