1Shubham7 / Wife-Predictor-v2

This is a fun project that predicts your wife. The web app has been deployed on Netlify.
https://wife-predictor.netlify.app/
MIT License
26 stars 27 forks source link

docs: enhance docs #15

Closed SrNightmare09 closed 1 year ago

SrNightmare09 commented 1 year ago
SrNightmare09 commented 1 year ago

I would also like to recommend that we should remove the about section of the readme as the information about the website is already provided below the main heading.

SrNightmare09 commented 1 year ago

The latest commit removes the additional underline when you hover over a link

Before After
image image
1Shubham7 commented 1 year ago

Thanks @SrNightmare09 for contributing but please make one change per PR, otherwise I will have to merge the entire PR. I can't merge this since the underline in the "GitHub" text is intentional. Can you make another PR making change in just docs.

1Shubham7 commented 1 year ago

@SrNightmare09 The best way to get PRs merged is to make small PRs with small changes so that I can roll back rather than 1 big PR with 5-6 commits. Also do one thing in one PR. If PR is about docs only do docs. For any other additions, you can open another PR.

SrNightmare09 commented 1 year ago

@1Shubham7 I have made the changes and reverted to only change in documentation.

1Shubham7 commented 1 year ago

@SrNightmare09 I told you the underline looks good. It is intentional. Please make PR for the other commits where you change the readme doc.

SrNightmare09 commented 1 year ago

@SrNightmare09 I told you the underline looks good. It is intentional. Please make PR for the other commits where you change the readme doc.

I have removed the changes to the css files, so the underline is still visible. I don't seem to understand what else you want from me.

1Shubham7 commented 1 year ago

@SrNightmare09 Its perfect now!! I am really sorry if this was annoying but mostly in open-source one should only do in the PR what he/she was assigned in the issue and make small PRs.

1Shubham7 commented 1 year ago

Thank you @SrNightmare09 for your time. Please contribute more. I really value your contributions.