1Shubham7 / Wife-Predictor-v2

This is a fun project that predicts your wife. The web app has been deployed on Netlify.
https://wife-predictor.netlify.app/
MIT License
29 stars 29 forks source link

Enhanced : adding some badges to the readme to make it look more visually appealing #26 #47

Closed Santhosh-Siddhardha closed 1 month ago

Santhosh-Siddhardha commented 1 month ago

Changes made

Issue solved : #26

1Shubham7 commented 1 month ago

Please share the SS for the changes you made. It is tough to evaluate otherwise...

Santhosh-Siddhardha commented 1 month ago

@1Shubham7 These are the changes I made

Screenshot 2024-05-10 204727

Screenshot 2024-05-10 204841

Screenshot 2024-05-10 204926

dhanyashreem2400 commented 1 month ago

Repeated statements

image

I would like to solve the issue

Santhosh-Siddhardha commented 1 month ago

Could you please mention the gssoc label and level label for this contribution. It will be helpful to my points

On Fri, May 10, 2024 at 9:00 PM Shubham Singh @.***> wrote:

Merged #47 https://github.com/1Shubham7/Wife-Predictor-v2/pull/47 into main.

— Reply to this email directly, view it on GitHub https://github.com/1Shubham7/Wife-Predictor-v2/pull/47#event-12771176762, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZOTNGW4GH5FMHTVMV5QHLZBTR2VAVCNFSM6AAAAABHQYUYGCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TCMJXGY3TMMQ . You are receiving this because you authored the thread.Message ID: @.***>

1Shubham7 commented 1 month ago

I am not sure about if I have to add the label in PR as well. Please remind me later, I will ask the GSSoC people. (Or you can show me a PR example from any other project in GSSoC.

Santhosh-Siddhardha commented 1 month ago

I asked this question in discord and One of the GSSoC people gave this reply, [image: image.png] So you can add the label, since you are project Admin

On Fri, May 10, 2024 at 9:29 PM Shubham Singh @.***> wrote:

I am not sure about if I have to add the label in PR as well. Please remind me later, I will ask the GSSoC people. (Or you can show me a PR example from any other project in GSSoC.

— Reply to this email directly, view it on GitHub https://github.com/1Shubham7/Wife-Predictor-v2/pull/47#issuecomment-2104853462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZOTNFDXOFS6KZXZWZTXN3ZBTVH7AVCNFSM6AAAAABHQYUYGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHA2TGNBWGI . You are receiving this because you authored the thread.Message ID: @.***>

Santhosh-Siddhardha commented 1 month ago

@1Shubham7 Please add the labels for PR also

Santhosh-Siddhardha commented 1 month ago

@1Shubham7 Please add gssoc and level label, otherwise they will not consider my points

Santhosh-Siddhardha commented 1 month ago

@1Shubham7 Thank you but label should be level2, there should not be any capitals and spaces. Then only they will consider

Santhosh-Siddhardha commented 1 month ago

@1Shubham7 Please add gssoc label and please assign this PR to me