search

1a1a11a / libCacheSim

a high performance library for building cache simulators
GNU General Public License v3.0
159 stars 34 forks source link

Set but unused variable #51

Closed nwf-msr closed 9 months ago

nwf-msr commented 9 months ago

ccache_params_copy in Random.c is set but not used thereafter: https://github.com/1a1a11a/libCacheSim/blob/eeae9891003dee054ea6df2b32e3a6dff7107663/libCacheSim/cache/eviction/Random.c#L48-L51 I suspect the ccache_params on line 51 wants to be ccache_params_copy instead?

ETA: Also https://github.com/1a1a11a/libCacheSim/blob/eeae9891003dee054ea6df2b32e3a6dff7107663/libCacheSim/cache/eviction/RandomTwo.c#L49-L53

1a1a11a commented 9 months ago

Good catch! Can you send a PR?