1activegeek / docker-airconnect

AirConnect container for turning Chromecast into Airplay targets
228 stars 27 forks source link

INC_MODELNUMBERS not working as expected #44

Closed robinwo closed 1 year ago

robinwo commented 1 year ago

Loading Airconnect via docker-compose, Defined INC_MODELNUMBERS environment variable to only include my PLAY:3 (S3).

  airconnect:
    image: 1activegeek/airconnect
    network_mode: host
    restart: unless-stopped
    environment:
      - SUPPRESS_FLUSH=TRUE
      - INCLUDE_AIRCAST=TRUE
      - INC_MODELNUMBERS=S3

Expected behavior is to only list 'Sonos Keuken+' in Airplay devices (via Airconnect), since this is the only PLAY:3 I have in my setup. Actual behavior is all Sonos devices continue to be listed (which are different models than PLAY:3). As a result I'm seeing Airplay 2 supported devices as duplicated.

Is this an issue with the INC_MODELNUMBERS setting, or a configuration problem on my end?

1activegeek commented 1 year ago

I'm not sure exactly what any of the environment variables you have included there are. So I would say yes this is a configuration problem. If those are entries that need to go into a config.xml then you can follow the details I've outlined on mapping a config file inside the container. At present though, those environment variables will not do anything in this container or relative to the original application itself I believe either as I don't see any documentation of such parameters.

1activegeek commented 1 year ago

App binary flags here: https://github.com/philippe44/AirConnect#common-information Config.xml parameters here: https://github.com/philippe44/AirConnect#config-file-parameters

robinwo commented 1 year ago

My mistake, I was mixing up the documentation in this repo with the documentation as listed in this other repo. Switching packages solved the issue - as expected now only showing S3 and Google devices for Airplay, all others only via regular Airplay2 protocol.