Multiarch support, S6 only (no supervisor), debian, ...

web2brain commented 4 years ago

Hello, I just saw that you also want to add multi architecture support. I forked your repository some time ago (and have to admit I did not create pull requests - sorry!) Meanwhile I changed some more things, so now you'll get a pull request for all of it. Feel free to decline and only pick the things you are interested in.. My changes include:

Support for multi architecture with automated docker hub builds
Remove supervisor, use S6 only
Move to debian, as it is smaller
Use ADD instead of curl during image creation
Other smaller things, like renaming the binary without the architecture in it.

If you want to include my changes, I'd be happy. If you want, just merge it all, but don't forget to change web2brain back to 1activegeek in the docu and most importantly in the manifest file 'multi-arch-manifest.yaml'

web2brain commented 4 years ago

One more comment about the multi arch support here: the builds in docker hub fail as long as there are not all tags mentioned in 'multi-arch-manifest.yaml' present. Once they are present, the builds will all complete without an error.

1activegeek commented 4 years ago

Thank you for the attempts, I was already working on most the changes needed on a dev branch. Appreciate the input and efforts but I'm going to leave this pull request out as this makes a lot of drastic changes that I'd rather not pull in.

1activegeek / docker-airconnect

Multiarch support, S6 only (no supervisor), debian, ... #9