1and1 / go-maven-poller

GoCD plugin that polls Maven repositories including Artifactory and Nexus
Other
9 stars 8 forks source link

JUnit 3 & 4 style mixing #7

Closed sfuhrm closed 9 years ago

sfuhrm commented 9 years ago

Instead of extending TestCase do

import static org.junit.Assert.*;

and then you can

assertEquals(a,b)

These files are affected:

stephan@nucleus:~/git/go-maven-poller$ grep "extends TestCase" . -R
./src/test/java/com/oneandone/go/plugin/maven/client/RepositoryConnectorTest.java:public class RepositoryConnectorTest extends TestCase {
./src/test/java/com/oneandone/go/plugin/maven/client/RepositoryResponseHandlerTest.java:public class RepositoryResponseHandlerTest extends TestCase {
./src/test/java/com/oneandone/go/plugin/maven/ConfigurationProviderTest.java:public class ConfigurationProviderTest extends TestCase {
stephan@nucleus:~/git/go-maven-poller$ 
bitionaire commented 9 years ago

Fixed with 2e650bd

sfuhrm commented 9 years ago

Good work!