search

1and1 / oneandone-cloudserver-sdk-nodejs

The official Node.js library for the 1&1 Cloud API.
Apache License 2.0
1 stars 5 forks source link

Filled out repo information #22

Closed tcrowe closed 5 years ago

tcrowe commented 5 years ago

What does it do?

TLDR: It makes it easier for developers to find information about the repo.

Currently, if you run this:

npm docs liboneandone
# open https://github.com/temp/temp#readme

npm info liboneandone repository
# { type: 'git', url: 'git+https://github.com/temp/temp.git' }

This PR fills in the information to point those URLs at your repo and documentation.

Additionally it adds npm test script and fixes these two issues: #20 #21

How to test?

git clone -b pkg-json-tweaks https://github.com/tcrowe/oneandone-cloudserver-sdk-nodejs.git liboneandone
cd liboneandone
npm install
npm test

I'm not sure how you guys get the tests to complete but you can see if this works. Maybe there is a test server or test cloud you run it on?

@siyb @Clement134 @alibazlamit Maybe you can review?

Thank you

tcrowe commented 5 years ago

The license said Apache 2 so I changed that in the package json too.

You guys can let me know if something is wrong with what I submitted.

tcrowe commented 5 years ago

Recommended test/mocha.opts file: https://gist.github.com/tcrowe/b22a63daea19eaee69fe2bc37adee854

Clement134 commented 5 years ago

If tests run with this new version of mocha, it looks good to me 👍

tcrowe commented 5 years ago

Is there any bandwidth to look at this? I'm not sure who owns it. @jhermann @Jochen-A-Fuerbacher @leonard84 @mfriedenhagen @mikey179 @mlhartme @thekid @wsdwl @xasx

People in the community are confused about this module: https://github.com/pkgcloud/pkgcloud/issues/644

This PR will help!

jhermann commented 5 years ago

As in a wiki , the truth can be found in the (commit) history. Most other people are just the org admins, and auto-added to each new repo

ScriptSmith commented 5 years ago

@tcrowe Is it worth publishing a package based on your fork, and then submitting a PR to pkgcloud to use it instead? It's frustrating for this to still be an issue.

tcrowe commented 5 years ago

Ideally we can get 1and1/IONOS to maintain the module but as you saw above there was no interest from the company yet.

npm owner ls liboneandone --registry=https://registry.npmjs.com
# alibazlamit <ali@stackpointcloud.com>
# oneandone <repositories@arsys.es>

Maybe if we make enough noise they'll take notice. I am periodically using this module with IONOS service. Maybe there is a re-brand so 1and1 become IONOS? I'm not sure who to talk to.

tcrowe commented 5 years ago

I've asked an associate of mine to also forward the link to support. Maybe they can reach the appropriate developers.

ScriptSmith commented 5 years ago

Yes, I was hoping to contact someone who could approve the changes. I emailed info@1und1.de a few days ago and explained the situation in an attempt to get them to approve the merge, but haven't heard anything back.

ScriptSmith commented 5 years ago

And yes, I agree that the IONOS / 1and1 / 1und1 branding is very confusing. The org still looks quite active, but the email they list at http://1and1.github.io/ just bounces.

mfriedenhagen commented 5 years ago

Maybe if we make enough noise they'll take notice. I am periodically using this module with IONOS service. Maybe there is a re-brand so 1and1 become IONOS? I'm not sure who to talk to.

The 1and1 group has three divisions (+-Hosting, Telecommunications, i.e. DSL&Mobile and classic Mail/Portal-provider) and the hosting division's new name is IONOS.

ScriptSmith commented 5 years ago

🎉 Thanks @ifernandez89

ScriptSmith commented 5 years ago

Is it possible to publish a new version on NPM?