search

1and2papa / CTAssetsPickerController

iOS control that allows picking multiple photos and videos from user's photo library.
MIT License
2.15k stars 550 forks source link

fix crash during device rotation #218

Closed Sega-Zero closed 8 years ago

Sega-Zero commented 8 years ago

In some rare cases, UICollectionView may throw an exception while items reloading (see http://stackoverflow.com/questions/13929518/ for example). The crash occurs when items size does not fit into CollectionView’s contentSize + offsets or having negative width/height. One possible reason of it is the case when (during a rotation) view.bound.size returns a very small size. This fix trying to catch that case and ignore all the rest code.

Couldn't reproduce that behavior on a clean project, but that crash occurs pretty frequently on 6+ devices in one of my production projects. It looks like this: ctassetsgridviewcontroller m edited 2016-03-25 01-43-46

1and2papa commented 8 years ago

@Sega-Zero This PR will be merged as pre-release too. Thanks.