search

1bacon / drops-into-shulker

Fabric mod that makes collected drops go into a shulker if it's in the offhand.
GNU General Public License v3.0
3 stars 1 forks source link

[BUG] item duplicate #4

Closed yoku0206 closed 10 months ago

yoku0206 commented 1 year ago

If shulker box can stack, the item will duplicate

yoku0206 commented 1 year ago

By the way i try it use carpet stackableShulkerBoxes

1bacon commented 10 months ago

Sorry I totally missed this. Can you describe what you did exactly? I'm guessing you stack empty shulkers, then take them into the off-hand and collect items. Those are then in all the shulkers of the stack?

I'll test this and get back to you.

1bacon commented 10 months ago

So yeah, I just tested it and it does dupe the drops. I'm not quite sure what to do here. Either don't allow pickups with multiple shulkers or force the other shulkers out and redirect the drops into the one remaining.

I think not redirecting the items and displaying some type of message is the easiest way.

1bacon commented 10 months ago

This should be fixed with 3ead0cd.

I'm closing this, but feel free to re-open when the problem is not fixed.