search

1bl4z3r / hermit-V2

Continuing Hermit's legacy to be minimal and fast theme
https://1bl4z3r.github.io/hermit-V2/
MIT License
79 stars 33 forks source link

Feature request: share button #36

Closed jamesbraza closed 10 months ago

jamesbraza commented 10 months ago

It would be cool to support a share button at the bottom of posts. It could be an opt-in feature, or enabled by default.

https://discourse.gohugo.io/t/share-buttons-for-blog-posts/12384 is a forum post with some ideas, the best seems to be https://codingnconcepts.com/hugo/social-icons-hugo/.

Thanks for your consideration, let me know what you think

1bl4z3r commented 10 months ago

Hi @jamesbraza

Share is something that I thought of implementing but decided against because it is complicated for no particular reason. Still I will check the links, but no promises though.

1bl4z3r commented 10 months ago

Hi again,

Can we reposition Share button from bottom of the page to bottom navigation bar? Using my site as an example, it gonna look like this. image In desktop, hovering on the button will open modal for the share links. However, in mobile, I haven't found a good place to put that yet, so open for suggestions.

Let me know if you like this

jamesbraza commented 10 months ago

Oh yeah, at the bottom of the page works too! You're right, it seems to make more sense there.

Good thinking on the modal too, like it.

1bl4z3r commented 10 months ago

Cool cool cool I will try to make something which follows Hermit styles as closely as possible.

1bl4z3r commented 10 months ago

Update: I got icon svg and location dialed down so that it looks coherent with the overall theme and not be an eyesore. Let me know if you have further suggestions.

In desktop, it will be at the extreme right hand. image

In mobile, it will be on the left of menu flyout image

jamesbraza commented 10 months ago

Yeah that share icon looks sweet actually, nice work! As far as placement, next to the other social icons seems like the right place. Good work so far

1bl4z3r commented 10 months ago

Update : I suck at styling anything.

What have I accomplished?

A new partial is added which will be invoked if site param is set. I have added Linkedin, X(Twitter), Email and Facebook

In desktop, it will be shown at extreme left. image

In mobile, it will also be on extreme left image

Have I used 100% of my brain capacity. Nope

1bl4z3r commented 10 months ago

Used up all my latent creativity to close this Issue. Re-open for modification (alongwith few pints of creative juices)

jamesbraza commented 10 months ago

Love it! I think you did a really nice job with it, thanks for doing this ❤️

I appreciate your efforts here!